linux-kernel - RE: [PATCH v3 1/3] hwrng: cctrng

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AM6PR08MB29990D46BD6C974ACE1914F0E9AA0@AM6PR08MB2999.eurprd08.prod.outlook.com>
Date:   Thu, 30 Apr 2020 08:26:00 +0000
From:   Hadar Gat <Hadar.Gat@....com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     Matt Mackall <mpm@...enic.com>, Arnd Bergmann <arnd@...db.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Krzysztof Kozlowski <krzk@...nel.org>,
        Stefan Wahren <wahrenst@....net>,
        Zaibo Xu <xuzaibo@...wei.com>,
        Tomer Maimon <tmaimon77@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Gilad Ben-Yossef <gilad@...yossef.com>,
        Ofir Drang <Ofir.Drang@....com>, nd <nd@....com>
Subject: RE: [PATCH v3 1/3] hwrng: cctrng - Add dependency on OF


> From: linux-crypto-owner@...r.kernel.org <linux-crypto-
> owner@...r.kernel.org> On Behalf Of Herbert Xu
> 
> On Thu, Apr 30, 2020 at 07:39:14AM +0000, Hadar Gat wrote:
> >
> > Yes, it builds, but it is useless.
> 
> But that's the whole point of COMPILE_TEST.

Herbert,
I don't understand if anything need to be fixed before this patch can be applied.
The patch adds dependency on OF, which was missing and is required for the cctrng driver.
(Indeed cctrng compilation passed also without CONFIG_OF because of the empty implementation of of_property_read*() functions that simply returns -ENOSYS.)

Hadar