linux-kernel - Re: [PATCH] iio: remove iio_get_debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b09ec4355ee35b03522afdac552aef38f08819db.camel@analog.com>
Date:   Thu, 30 Apr 2020 09:01:47 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
CC:     "jic23@...nel.org" <jic23@...nel.org>
Subject: Re: [PATCH] iio: remove iio_get_debugfs_dentry() helper

On Thu, 2020-04-30 at 11:52 +0300, Alexandru Ardelean wrote:
> Not used anywhere.
> Looks like it was forgotten in iio.h
> 

Actually, disregard this.
I've found places where 'indio_dev->debugfs_dentry' is accessed directly and
that should have used this instead.

Apologies for the spam. 


> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
> ---
>  include/linux/iio/iio.h | 16 ----------------
>  1 file changed, 16 deletions(-)
> 
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index 38c4ea505394..1a1da52c55cf 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -696,22 +696,6 @@ static inline bool iio_buffer_enabled(struct iio_dev
> *indio_dev)
>  		   INDIO_BUFFER_SOFTWARE);
>  }
>  
> -/**
> - * iio_get_debugfs_dentry() - helper function to get the debugfs_dentry
> - * @indio_dev:		IIO device structure for device
> - **/
> -#if defined(CONFIG_DEBUG_FS)
> -static inline struct dentry *iio_get_debugfs_dentry(struct iio_dev
> *indio_dev)
> -{
> -	return indio_dev->debugfs_dentry;
> -}
> -#else
> -static inline struct dentry *iio_get_debugfs_dentry(struct iio_dev
> *indio_dev)
> -{
> -	return NULL;
> -}
> -#endif
> -
>  ssize_t iio_format_value(char *buf, unsigned int type, int size, int *vals);
>  
>  int iio_str_to_fixpoint(const char *str, int fract_mult, int *integer,