linux-kernel - Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap() call in zynq_cpun

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f07532ca-0bf3-7e1b-2d53-6f5555d5e451@xilinx.com>
Date:   Thu, 30 Apr 2020 11:19:57 +0200
From:   Michal Simek <michal.simek@...inx.com>
To:     Markus Elfring <Markus.Elfring@....de>,
        Xu Wang <vulab@...as.ac.cn>,
        linux-arm-kernel@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, Russell King <linux@...linux.org.uk>,
        Michal Simek <michal.simek@...inx.com>
Subject: Re: [PATCH] ZYNQ: platsmp: Return -ENOMEM after a failed ioremap()
 call in zynq_cpun_start()

On 30. 04. 20 11:00, Markus Elfring wrote:
>> In ioremap we should return -ENOMEM when it reports an
>> memory allocation failure.
> 
> I suggest to improve this change description.
> 
> Will the tag “Fixes” be relevant because of the adjusted error code?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=1d2cc5ac6f6668cc15216d51051103c61467d7e8#n183

I don't think this was found by bisection because arm smp code cares
only about 0 - success and !0. I would expect any static program
analysis tool like coccinelle.

Would be good to rewrite that commit message and simply say that
failures from ioremaps returns -ENOMEM.

Thanks,
Michal