linux-kernel - Re: [PATCH] drm/vboxvideo: Fix a NULL vs IS_ERR() check in vbox_hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <32389e2b-50e8-8bd4-ee7c-5c6dfa273c00@web.de>
Date:   Thu, 30 Apr 2020 11:30:38 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Wei Yongjun <weiyongjun1@...wei.com>,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH] drm/vboxvideo: Fix a NULL vs IS_ERR() check in
 vbox_hw_init()

> The devm_gen_pool_create() function returns ERR_PTR() on error, it
> doesn't return NULL so this check doesn't work.

How do you think about a wording variant like the following?

   Change description:
   A null pointer check was performed after a call of the
   function “devm_gen_pool_create” despite of the detail
   that failures are indicated by error pointers instead.
   Thus adjust a check for the failure predicate
   and return the corresponding error code.

Regards,
Markus