linux-kernel - Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200430095559.GB28579@bogus>
Date:   Thu, 30 Apr 2020 10:55:59 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Xiongfeng Wang <wangxiongfeng2@...wei.com>
Cc:     rjw@...ysocki.net, viresh.kumar@...aro.org,
        linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        guohanjun@...wei.com, john.garry@...wei.com,
        Sudeep Holla <sudeep.holla@....com>
Subject: Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote:
> HiSilicon SoC has a separate System Control Processor(SCP) dedicated for
> clock frequency adjustment and has been using the cpufreq driver
> 'cppc-cpufreq'. New HiSilicon SoC HIP09 add support for CPU Boost, but
> ACPI CPPC doesn't support this. In HiSilicon SoC HIP09, each core has
> its own clock domain. It is better for the core itself to adjust its
> frequency when we require fast response. In this patch, we add a
> separate cpufreq driver for HiSilicon SoC HIP09.
>

I disagree with this approach unless you have tried to extend the CPPC
in ACPI to accommodate this boost feature you need. Until you show those
efforts and disagreement to do that from ASWG, I am NACKing this approach.

--
Regards,
Sudeep