| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Apr 2020 13:05:12 +0300
From: Abel Vesa <abel.vesa@....com>
To: Anson Huang <Anson.Huang@....com>
Cc: mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, linux-clk@...r.kernel.org,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org, Linux-imx@....com
Subject: Re: [PATCH V4 1/5] dt-bindings: clock: Convert i.MX6Q clock to
json-schema
On 20-04-30 08:51:57, Anson Huang wrote:
> Convert the i.MX6Q clock binding to DT schema format using json-schema.
>
> Signed-off-by: Anson Huang <Anson.Huang@....com>
Great effort taking care of these.
Reviewed-by: Abel Vesa <abel.vesa@....com>
> ---
> Changes since V3:
> - update license to be with (GPL-2.0-only OR BSD-2-Clause);
> - remove unnecessary minItem for interrupts;
> - remove label in example.
> ---
> .../devicetree/bindings/clock/imx6q-clock.txt | 41 --------------
> .../devicetree/bindings/clock/imx6q-clock.yaml | 66 ++++++++++++++++++++++
> 2 files changed, 66 insertions(+), 41 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.txt
> create mode 100644 Documentation/devicetree/bindings/clock/imx6q-clock.yaml
>
> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt b/Documentation/devicetree/bindings/clock/imx6q-clock.txt
> deleted file mode 100644
> index 13d36d4..0000000
> --- a/Documentation/devicetree/bindings/clock/imx6q-clock.txt
> +++ /dev/null
> @@ -1,41 +0,0 @@
> -* Clock bindings for Freescale i.MX6 Quad
> -
> -Required properties:
> -- compatible: Should be "fsl,imx6q-ccm"
> -- reg: Address and length of the register set
> -- interrupts: Should contain CCM interrupt
> -- #clock-cells: Should be <1>
> -
> -Optional properties:
> -- fsl,pmic-stby-poweroff: Configure CCM to assert PMIC_STBY_REQ signal
> - on power off.
> - Use this property if the SoC should be powered off by external power
> - management IC (PMIC) triggered via PMIC_STBY_REQ signal.
> - Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should
> - be using "syscon-poweroff" driver instead.
> -- clocks: list of clock specifiers, must contain an entry for each entry
> - in clock-names
> -- clock-names: valid names are "osc", "ckil", "ckih1", "anaclk1" and "anaclk2"
> -
> -The clock consumer should specify the desired clock by having the clock
> -ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx6qdl-clock.h
> -for the full list of i.MX6 Quad and DualLite clock IDs.
> -
> -Examples:
> -
> -#include <dt-bindings/clock/imx6qdl-clock.h>
> -
> -clks: ccm@...4000 {
> - compatible = "fsl,imx6q-ccm";
> - reg = <0x020c4000 0x4000>;
> - interrupts = <0 87 0x04 0 88 0x04>;
> - #clock-cells = <1>;
> -};
> -
> -uart1: serial@...0000 {
> - compatible = "fsl,imx6q-uart", "fsl,imx21-uart";
> - reg = <0x02020000 0x4000>;
> - interrupts = <0 26 0x04>;
> - clocks = <&clks IMX6QDL_CLK_UART_IPG>, <&clks IMX6QDL_CLK_UART_SERIAL>;
> - clock-names = "ipg", "per";
> -};
> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> new file mode 100644
> index 0000000..0dc96ed
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> @@ -0,0 +1,66 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fclock%2Fimx6q-clock.yaml%23&data=02%7C01%7Cabel.vesa%40nxp.com%7Ca9ea8978c18a400f965d08d7eca1eec5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637238052550722964&sdata=vZmcBuigGFCbh1doAasvlXKFltD%2Fu9T4i88KWRoxck8%3D&reserved=0
> +$schema: https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=02%7C01%7Cabel.vesa%40nxp.com%7Ca9ea8978c18a400f965d08d7eca1eec5%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637238052550722964&sdata=RyT292O7qdkbmKrSMXEuHCo%2Fezm98n%2FAAYpansFL3%2BY%3D&reserved=0
> +
> +title: Clock bindings for Freescale i.MX6 Quad
> +
> +maintainers:
> + - Anson Huang <Anson.Huang@....com>
> +
> +properties:
> + compatible:
> + const: fsl,imx6q-ccm
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 2
> +
> + '#clock-cells':
> + const: 1
> +
> + clocks:
> + items:
> + - description: 24m osc
> + - description: 32k osc
> + - description: ckih1 clock input
> + - description: anaclk1 clock input
> + - description: anaclk2 clock input
> +
> + clock-names:
> + items:
> + - const: osc
> + - const: ckil
> + - const: ckih1
> + - const: anaclk1
> + - const: anaclk2
> +
> + fsl,pmic-stby-poweroff:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description: |
> + Use this property if the SoC should be powered off by external power
> + management IC (PMIC) triggered via PMIC_STBY_REQ signal.
> + Boards that are designed to initiate poweroff on PMIC_ON_REQ signal should
> + be using "syscon-poweroff" driver instead.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - '#clock-cells'
> +
> +examples:
> + # Clock Control Module node:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + clock-controller@...4000 {
> + compatible = "fsl,imx6q-ccm";
> + reg = <0x020c4000 0x4000>;
> + interrupts = <0 87 IRQ_TYPE_LEVEL_HIGH>,
> + <0 88 IRQ_TYPE_LEVEL_HIGH>;
> + #clock-cells = <1>;
> + };
> --
> 2.7.4
>
Powered by blists - more mailing lists