linux-kernel - Re: [PATCH v7 2/7] tpm: tpm_tis: Add verify_data_integrity handle toy tpm_tis_phy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 30 Apr 2020 10:19:09 +0000
From:   Amir Mizinski <amirmizi6@...il.com>
To:     Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
Cc:     Eyal.Cohen@...oton.com, oshrialkoby85@...il.com,
        alexander.steffen@...ineon.com, robh+dt@...nel.org,
        mark.rutland@....com, peterhuewe@....de, jgg@...pe.ca,
        arnd@...db.de, gregkh@...uxfoundation.org, benoit.houyere@...com,
        eajames@...ux.ibm.com, joel@....id.au, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-integrity@...r.kernel.org,
        oshri.alkoby@...oton.com, tmaimon77@...il.com, gcwilson@...ibm.com,
        kgoldman@...ibm.com, Dan.Morav@...oton.com,
        oren.tanami@...oton.com, shmulik.hager@...oton.com,
        amir.mizinski@...oton.com,
        Christophe Ricard <christophe-h.ricard@...com>
Subject: Re: [PATCH v7 2/7] tpm: tpm_tis: Add verify_data_integrity handle toy
 tpm_tis_phy_ops


On 2020-04-29 05:34, Jarkko Sakkinen wrote:
> On Mon, Apr 27, 2020 at 03:49:26PM +0300, amirmizi6@...il.com wrote:
>> +    bool (*verify_data_integrity)(struct tpm_tis_data *data, const u8 *buf,
>> +                      size_t len);
>
> Why can't the i2c driver verify this in the end of read_bytes()?
>

The TPM calculates the checksum of the entire command data at the end
of command transmission or the checksum of the entire response data at the
end of response transmission.
read_bytes is not necessarily called at the end of response transmission. Same for write_bytes.

> /Jarkko