lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 30 Apr 2020 13:56:23 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Wei Yongjun <weiyongjun1@...wei.com>, dri-devel@...ts.freedesktop.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org, Daniel Vetter <daniel@...ll.ch>, David Airlie <airlied@...ux.ie>, Linus Walleij <linus.walleij@...aro.org> Subject: Re: [PATCH v2] drm/mcde: dsi: Fix return value check in mcde_dsi_bind() > The of_drm_find_bridge() function returns NULL on error, it doesn't return > error pointers so this check doesn't work. How do you think about a wording variant like the following? Change description: An error pointer check was performed after a call of the function “of_drm_find_bridge” despite of the detail that failures are indicated for the bridge search by null pointers instead. Thus adjust a check for the failure predicate and the corresponding exception handling. Regards, Markus
Powered by blists - more mailing lists