linux-kernel - Re: [PATCH 1/4] counter: Internalize sysfs interface code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200430131354.GA3526@icarus>
Date:   Thu, 30 Apr 2020 09:13:54 -0400
From:   William Breathitt Gray <vilhelm.gray@...il.com>
To:     kbuild test robot <lkp@...el.com>
Cc:     jic23@...nel.org, kbuild-all@...ts.01.org,
        kamel.bouhara@...tlin.com, gwendal@...omium.org,
        alexandre.belloni@...tlin.com, david@...hnology.com,
        felipe.balbi@...ux.intel.com, fabien.lahoudere@...labora.com,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH 1/4] counter: Internalize sysfs interface code

On Thu, Apr 30, 2020 at 03:41:26PM +0800, kbuild test robot wrote:
> Hi William,
> 
> I love your patch! Yet something to improve:
> 
> [auto build test ERROR on stm32/stm32-next]
> [cannot apply to linus/master linux/master v5.7-rc3 next-20200429]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
> 
> url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20200430-051734
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
> config: x86_64-allyesconfig (attached as .config)
> compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=x86_64 
> 
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kbuild test robot <lkp@...el.com>
> 
> All errors (new ones prefixed by >>):
> 
> >> drivers/counter/stm32-lptimer-cnt.c:387:2: error: initializer element is not constant
>      stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_RISING_EDGE],
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/counter/stm32-lptimer-cnt.c:387:2: note: (near initialization for 'stm32_lptim_cnt_synapse_actions[0]')
>    drivers/counter/stm32-lptimer-cnt.c:388:2: error: initializer element is not constant
>      stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_FALLING_EDGE],
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/counter/stm32-lptimer-cnt.c:388:2: note: (near initialization for 'stm32_lptim_cnt_synapse_actions[1]')
>    drivers/counter/stm32-lptimer-cnt.c:389:2: error: initializer element is not constant
>      stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_BOTH_EDGES],
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/counter/stm32-lptimer-cnt.c:389:2: note: (near initialization for 'stm32_lptim_cnt_synapse_actions[2]')
>    drivers/counter/stm32-lptimer-cnt.c:390:2: error: initializer element is not constant
>      stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_NONE],
>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/counter/stm32-lptimer-cnt.c:390:2: note: (near initialization for 'stm32_lptim_cnt_synapse_actions[3]')
> 
> vim +387 drivers/counter/stm32-lptimer-cnt.c
> 
>    385	
>    386	static const enum counter_synapse_action stm32_lptim_cnt_synapse_actions[] = {
>  > 387		stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_RISING_EDGE],
>    388		stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_FALLING_EDGE],
>    389		stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_BOTH_EDGES],
>    390		stm32_lptim_l2c_actions_map[STM32_LPTIM_SYNAPSE_ACTION_NONE],
>    391	};
>    392	
> 
> ---
> 0-DAY CI Kernel Test Service, Intel Corporation
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

This array must be initialized with constants. I'll fix this up in v2.

Thanks,

William Breathitt Gray

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)