linux-kernel - Re: [PATCH 1/4] counter: Internalize sysfs interface code (fwd)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.2005011825030.2504@hadrien>
Date:   Fri, 1 May 2020 18:27:07 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...ia.fr>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
cc:     linux-stm32@...md-mailman.stormreply.com,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
        fabien.lahoudere@...labora.com, felipe.balbi@...ux.intel.com,
        david@...hnology.com, alexandre.belloni@...tlin.com,
        gwendal@...omium.org, kamel.bouhara@...tlin.com, jic23@...nel.org,
        kbuild-all@...ts.01.org
Subject: Re: [PATCH 1/4] counter: Internalize sysfs interface code (fwd)

Hello,

Normally, the argument of kfree should not start with &.

julia

---------- Forwarded message ----------
Date: Fri, 1 May 2020 06:07:26 +0800
From: kbuild test robot <lkp@...el.com>
To: kbuild@...ts.01.org
Cc: lkp@...el.com, Julia Lawall <julia.lawall@...6.fr>
Subject: Re: [PATCH 1/4] counter: Internalize sysfs interface code

CC: kbuild-all@...ts.01.org
In-Reply-To: <d84f0bb3258d1664e90da64d75f787829c50a9bd.1588176662.git.vilhelm.gray@...il.com>
References: <d84f0bb3258d1664e90da64d75f787829c50a9bd.1588176662.git.vilhelm.gray@...il.com>
TO: William Breathitt Gray <vilhelm.gray@...il.com>
TO: jic23@...nel.org
CC: kamel.bouhara@...tlin.com
CC: gwendal@...omium.org
CC: alexandre.belloni@...tlin.com
CC: david@...hnology.com
CC: felipe.balbi@...ux.intel.com
CC: fabien.lahoudere@...labora.com
CC: linux-iio@...r.kernel.org
CC: linux-kernel@...r.kernel.org
CC: linux-stm32@...md-mailman.stormreply.com

Hi William,

I love your patch! Perhaps something to improve:

[auto build test WARNING on stm32/stm32-next]
[cannot apply to linus/master linux/master v5.7-rc3 next-20200430]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-Counter-character-device-interface/20200430-051734
base:   https://git.kernel.org/pub/scm/linux/kernel/git/atorgue/stm32.git stm32-next
:::::: branch date: 25 hours ago
:::::: commit date: 25 hours ago

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>
Reported-by: Julia Lawall <julia.lawall@...6.fr>


coccinelle warnings: (new ones prefixed by >>)

>> drivers/counter/counter-core.c:26:1-6: ERROR: invalid free of structure field

# https://github.com/0day-ci/linux/commit/bdd9a6aa70c61f16dacaf057f0ce70fc210b5ec9
git remote add linux-review https://github.com/0day-ci/linux
git remote update linux-review
git checkout bdd9a6aa70c61f16dacaf057f0ce70fc210b5ec9
vim +26 drivers/counter/counter-core.c

bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  20
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  21  static void counter_device_release(struct device *dev)
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  22  {
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  23  	struct counter_device *const counter = dev_get_drvdata(dev);
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  24
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  25  	counter_sysfs_free(counter);
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29 @26  	kfree(&counter->dev);
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  27  	ida_simple_remove(&counter_ida, counter->id);
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  28  }
bdd9a6aa70c61f1 William Breathitt Gray 2020-04-29  29

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org