linux-kernel - Re: [PATCH] dt-bindings: power: Convert power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200501165829.2y2soxprt6naemki@earth.universe>
Date:   Fri, 1 May 2020 18:58:29 +0200
From:   Sebastian Reichel <sebastian.reichel@...labora.com>
To:     Dan Murphy <dmurphy@...com>
Cc:     linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh@...nel.org>
Subject: Re: [PATCH] dt-bindings: power: Convert power_supply text to yaml

Hi,

On Thu, Apr 30, 2020 at 10:18:41AM -0500, Dan Murphy wrote:
> Convert the power_supply.txt to power-supply.yaml.
> This conversion entailed fixing up the binding to being yaml and dt
> checker compliant.

Looks mostly good to me, thanks for taking care of it.

> Added a note in the power_supply.txt to reference the power-supply.yaml

Yes, we should keep the file until all bindings referencing the file
have been converted to YAML.

> CC: Rob Herring <robh@...nel.org>
> Signed-off-by: Dan Murphy <dmurphy@...com>
> ---
>  .../bindings/power/supply/power-supply.yaml   | 40 +++++++++++++++++++
>  .../bindings/power/supply/power_supply.txt    | 25 +-----------
>  2 files changed, 42 insertions(+), 23 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/power-supply.yaml
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/power-supply.yaml b/Documentation/devicetree/bindings/power/supply/power-supply.yaml
> new file mode 100644
> index 000000000000..cfbc79833ed8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/power-supply.yaml
> @@ -0,0 +1,40 @@
> +# SPDX-License-Identifier: GPL-2.0
> +%YAML 1.2
> +---
> +$id: "http://devicetree.org/schemas/power/supply/power_supply.yaml#"

This should be power-supply instead of power_supply, which is also
reported by dtb_binding_check on my system :)

> +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> +
> +title: Power Supply Core Support
> +
> +maintainers:
> +  - Sebastian Reichel <sre@...nel.org>
> +
> +properties:
> +  power-supplies:
> +    $ref: /schemas/types.yaml#/definitions/phandle-array
> +    description:
> +      This property is added to a supply in order to list the devices which
> +      supply it power, referenced by their phandles.
> +
> +examples:
> +  - |
> +    power {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      usb_charger:power@e {
> +        compatible = "some,usb-charger";
> +        reg = <0xe>;
> +      };
> +
> +      ac_charger:power@c {

^^^ while at it, let's also fix this up and use
charger instead of power (for both entries).

> +        compatible = "some,ac-charger";
> +        reg = <0xc>;
> +      };
> +
> +      battery:battery@b {
> +        compatible = "some,battery";
> +        reg = <0xb>;
> +        power-supplies = <&usb_charger>, <&ac_charger>;
> +      };
> +    };
> diff --git a/Documentation/devicetree/bindings/power/supply/power_supply.txt b/Documentation/devicetree/bindings/power/supply/power_supply.txt
> index 8391bfa0edac..d9693e054509 100644
> --- a/Documentation/devicetree/bindings/power/supply/power_supply.txt
> +++ b/Documentation/devicetree/bindings/power/supply/power_supply.txt
> @@ -1,23 +1,2 @@
> -Power Supply Core Support
> -
> -Optional Properties:
> - - power-supplies : This property is added to a supply in order to list the
> -   devices which supply it power, referenced by their phandles.
> -
> -Example:
> -
> -	usb-charger: power@e {
> -		compatible = "some,usb-charger";
> -		...
> -	};
> -
> -	ac-charger: power@c {
> -		compatible = "some,ac-charger";
> -		...
> -	};
> -
> -	battery@b {
> -		compatible = "some,battery";
> -		...
> -		power-supplies = <&usb-charger>, <&ac-charger>;
> -	};
> +This binding has been converted to yaml please see power-supply.yaml in this
> +directory.
> -- 
> 2.25.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)