linux-kernel - Re: [PATCH v4 01/10] loop: Factor out loop size validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200501172634.GA22792@lst.de>
Date:   Fri, 1 May 2020 19:26:34 +0200
From:   Christoph Hellwig <hch@....de>
To:     Ming Lei <ming.lei@...hat.com>
Cc:     Martijn Coenen <maco@...roid.com>, axboe@...nel.dk, hch@....de,
        narayan@...gle.com, zezeozue@...gle.com, kernel-team@...roid.com,
        maco@...gle.com, bvanassche@....org, Chaitanya.Kulkarni@....com,
        jaegeuk@...nel.org, linux-block@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 01/10] loop: Factor out loop size validation

On Wed, Apr 29, 2020 at 10:12:29PM +0800, Ming Lei wrote:
> > +static int
> > +loop_validate_size(loff_t size)
> > +{
> > +	if ((loff_t)(sector_t)size != size)
> > +		return -EFBIG;
> > +
> > +	return 0;
> > +}
> > +
> 
> Now sector_t has been switched to u64 unconditionally, do we still need such
> validation?

Oops, completely forgot about that.  Yes, we can just kill the
checks.