linux-kernel - Re: [PATCH] lan743x: Added fixed_phy support / Question regarding proper devicetree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20200501184532.GI128733@lunn.ch>
Date:   Fri, 1 May 2020 20:45:32 +0200
From:   Andrew Lunn <andrew@...n.ch>
To:     Roelof Berg <rberg@...g-solutions.de>
Cc:     "David S. Miller" <davem@...emloft.net>,
        Bryan Whitehead <bryan.whitehead@...rochip.com>,
        Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
        Russell King <linux@...linux.org.uk>,
        Thomas Gleixner <tglx@...utronix.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lan743x: Added fixed_phy support / Question regarding
 proper devicetree

On Fri, May 01, 2020 at 08:09:05PM +0200, Roelof Berg wrote:
> Working status: I added fixed_phy support to the Microchip lan743x ethernet
> driver and for upstream contribution I need to make it runtime configurable via
> the device tree.
> 
> Question:
> 
> There are, amongst other, the following devices on my target (i.mx6): 
> /soc/aips-bus@...0000/ethernet@...8000
> /soc/pcie@...c000
> 
> Where would I put my additional lan743x ethernet device in the device tree ?

It is a child device of the PCIe host. So that decides where it goes
in the tree. The pcie bus should already be in the imx6 DTSI file. So
in your board specific dts file you want something like:

&pcie {
        host@0 {
                reg = <0 0 0 0 0>;

                #address-cells = <3>;
                #size-cells = <2>;

                ethernet: ethernet@0 {
                        reg = <0 0 0 0 0>;
			phy-connection-type = "rgmii";
                         
                        fixed-link {
                                speed = <100>;
                                full-duplex;
                        };
                };
         };
};

You will probably need to play around with this. It is not well
documented, there are few examples. I needed to put a few printk() in
the PCI core to get it working for the ZII boards.

    Andrew