linux-kernel - Re: [PATCH v4] eventfd: convert to f_op->read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <03867cf3-d5e7-cc29-37d2-1a417a58af45@kernel.dk>
Date:   Fri, 1 May 2020 17:54:09 -0600
From:   Jens Axboe <axboe@...nel.dk>
To:     Al Viro <viro@...iv.linux.org.uk>
Cc:     linux-fsdevel <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] eventfd: convert to f_op->read_iter()

On 5/1/20 5:12 PM, Al Viro wrote:
> On Fri, May 01, 2020 at 01:11:09PM -0600, Jens Axboe wrote:
>> +	flags &= EFD_SHARED_FCNTL_FLAGS;
>> +	flags |= O_RDWR;
>> +	fd = get_unused_fd_flags(flags);
>>  	if (fd < 0)
>> -		eventfd_free_ctx(ctx);
>> +		goto err;
>> +
>> +	file = anon_inode_getfile("[eventfd]", &eventfd_fops, ctx, flags);
>> +	if (IS_ERR(file)) {
>> +		put_unused_fd(fd);
>> +		fd = PTR_ERR(file);
>> +		goto err;
>> +	}
>>  
>> +	file->f_mode |= FMODE_NOWAIT;
>> +	fd_install(fd, file);
>> +	return fd;
>> +err:
>> +	eventfd_free_ctx(ctx);
>>  	return fd;
>>  }
> 
> Looks sane...  I can take it via vfs.git, or leave it for you if you
> have other stuff in the same area...

Would be great if you can queue it up in vfs.git, thanks! Don't have
anything else that'd conflict with this.

-- 
Jens Axboe