linux-kernel - Re: [PATCH] MIPS: tools: Show result for loongson3-llsc-check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 1 May 2020 12:48:03 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>
Cc:     linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH] MIPS: tools: Show result for loongson3-llsc-check

Hello!

On 30.04.2020 15:36, Tiezhu Yang wrote:

> It is better to show the result before loongson3-llsc-check exit,
> otherwise we can see nothing if the return status is EXIT_SUCCESS,
> it seems confusing.
> 
> E.g. without this patch:
> 
> [loongson@...alhost tools]$ ./loongson3-llsc-check ../../../vmlinux
> [loongson@...alhost tools]$
> 
> With this patch:
> 
> [loongson@...alhost tools]$ ./loongson3-llsc-check ../../../vmlinux
> loongson3-llsc-check returns success
> [loongson@...alhost tools]$
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>
> ---
>   arch/mips/tools/loongson3-llsc-check.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/arch/mips/tools/loongson3-llsc-check.c b/arch/mips/tools/loongson3-llsc-check.c
> index 0ebddd0..facd016 100644
> --- a/arch/mips/tools/loongson3-llsc-check.c
> +++ b/arch/mips/tools/loongson3-llsc-check.c
> @@ -303,5 +303,7 @@ int main(int argc, char *argv[])
>   out_close:
>   	close(vmlinux_fd);
>   out_ret:
> +	fprintf(stdout, "loongson3-llsc-check %s\n",
> +		status ? "returns failure" : "returns success");

    Why not "loongson3-llsc-check returns %s\n"?

>   	return status;
>   }
> 

MBR, Sergei