linux-kernel - RE: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return status

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BYAPR02MB3941AE74C305FD0452E2B868B7AB0@BYAPR02MB3941.namprd02.prod.outlook.com>
Date:   Fri, 1 May 2020 10:54:36 +0000
From:   Rajan Vaja <RAJANV@...inx.com>
To:     Greg KH <gregkh@...uxfoundation.org>
CC:     "herbert@...dor.apana.org.au" <herbert@...dor.apana.org.au>,
        "davem@...emloft.net" <davem@...emloft.net>,
        Kalyani Akula <kalyania@...inx.com>,
        Michal Simek <michals@...inx.com>,
        Jolly Shah <JOLLYS@...inx.com>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return
 status

Thanks Gerg for review.

I have updated reported by and fixes tag properly now. Sent v2.

Thanks
Rajan

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Friday, May 1, 2020 4:00 PM
> To: Rajan Vaja <RAJANV@...inx.com>
> Cc: herbert@...dor.apana.org.au; davem@...emloft.net; Kalyani Akula
> <kalyania@...inx.com>; Michal Simek <michals@...inx.com>; Jolly Shah
> <JOLLYS@...inx.com>; linux-crypto@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH char-misc-next] crypto: xilinx: Handle AES PM API return
> status
> 
> CAUTION: This message has originated from an External Source. Please use
> proper judgment and caution when opening attachments, clicking links, or
> responding to this email.
> 
> 
> On Fri, May 01, 2020 at 03:14:51AM -0700, Rajan Vaja wrote:
> > Fixes: bc86f9c54616 ("firmware: xilinx: Remove eemi ops for aes
> > engine")
> >
> > Return value of AES PM API is not handled which may result in
> > unexpected value of "status" in zynqmp_pm_aes_engine().
> >
> > Consider "status" value as valid only if AES PM API is successful.
> >
> > Signed-off-by: Rajan Vaja <rajan.vaja@...inx.com>
> 
> No "Reported-by:" line?
> 
> And put the "Fixes:" line down in the s-o-b area please.
> 
> thanks,
> 
> greg k-h