lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 May 2020 02:49:54 +0100 From: Al Viro <viro@...iv.linux.org.uk> To: Matthew Wilcox <willy@...radead.org> Cc: Guoqing Jiang <guoqing.jiang@...ud.ionos.com>, linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, hch@...radead.org, david@...morbit.com, Andrew Morton <akpm@...ux-foundation.org>, "Darrick J. Wong" <darrick.wong@...cle.com>, William Kucharski <william.kucharski@...cle.com>, "Kirill A. Shutemov" <kirill.shutemov@...ux.intel.com>, Andreas Gruenbacher <agruenba@...hat.com>, Yang Shi <yang.shi@...ux.alibaba.com>, Yafang Shao <laoar.shao@...il.com>, Song Liu <song@...nel.org>, linux-raid@...r.kernel.org, Chris Mason <clm@...com>, Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>, linux-btrfs@...r.kernel.org, Jaegeuk Kim <jaegeuk@...nel.org>, Chao Yu <chao@...nel.org>, linux-f2fs-devel@...ts.sourceforge.net, linux-xfs@...r.kernel.org, Anton Altaparmakov <anton@...era.com>, linux-ntfs-dev@...ts.sourceforge.net, Mike Marshall <hubcap@...ibond.com>, Martin Brandenburg <martin@...ibond.com>, devel@...ts.orangefs.org, Thomas Gleixner <tglx@...utronix.de>, Sebastian Andrzej Siewior <bigeasy@...utronix.de>, Roman Gushchin <guro@...com>, Andreas Dilger <adilger@...ger.ca> Subject: Re: [RFC PATCH V2 1/9] include/linux/pagemap.h: introduce attach/clear_page_private On Fri, May 01, 2020 at 02:42:29AM +0100, Al Viro wrote: > On Thu, Apr 30, 2020 at 03:13:38PM -0700, Matthew Wilcox wrote: > > > > +/** > > > + * clear_page_private - clear page's private field and PG_private. > > > + * @page: page to be cleared. > > > + * > > > + * The counterpart function of attach_page_private. > > > + * Return: private data of page or NULL if page doesn't have private data. > > > + */ > > > > Seems to me that the opposite of "attach" is "detach", not "clear". > > Or "remove", perhaps... Actually, "detach" is better - neither "clear" nor "remove" imply "... and give me what used to be attached there", as this thing is doing.
Powered by blists - more mailing lists