lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 1 May 2020 03:09:12 +0100
From:   Al Viro <>
        Andrew Morton <>,
        Christian Koenig <>,
        Huang Rui <>,
        Thomas Bogendoerfer <>,
        "James E.J. Bottomley" <>,
        Helge Deller <>,
        Benjamin Herrenschmidt <>,
        Paul Mackerras <>,
        "David S. Miller" <>,
        Thomas Gleixner <>,
        Ingo Molnar <>, Borislav Petkov <>,, "H. Peter Anvin" <>,
        Dave Hansen <>,
        Andy Lutomirski <>,
        Peter Zijlstra <>,
        Chris Zankel <>,
        Max Filippov <>,
        Dan Williams <>,,,,,,,,,
Subject: Re: [PATCH V1 05/10] arch/kmap_atomic: Consolidate duplicate code

On Thu, Apr 30, 2020 at 01:38:40PM -0700, wrote:
> From: Ira Weiny <>
> Every arch has the same code to ensure atomic operations and a check for
> !HIGHMEM page.
> Remove the duplicate code by defining a core kmap_atomic() which only
> calls the arch specific kmap_atomic_high() when the page is high memory.

Err....  AFAICS, you've just silently changed the semantics for
kmap_atomic_prot() here.  And while most of the callers are converted,
drivers/gpu/drm/ttm/ttm_bo_util.c one is not, so at the very least it's
a bisect hazard...

And I would argue that having kmap_atomic() differ from kmap_atomic_prot()
wrt disabling preempt is asking for trouble.

Powered by blists - more mailing lists