linux-kernel - Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 02 May 2020 09:27:31 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Lukas Wunner <lukas@...ner.de>
Cc:     Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>,
        Alex Deucher <alexdeucher@...il.com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        Takashi Iwai <tiwai@...e.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>
Subject: Re: [PATCH 0/1] Fiji GPU audio register timeout when in BACO state

On Sat, 02 May 2020 09:17:28 +0200,
Lukas Wunner wrote:
> 
> On Sat, May 02, 2020 at 09:11:58AM +0200, Takashi Iwai wrote:
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -673,6 +673,12 @@ static int amdgpu_dm_audio_component_bind(struct device *kdev,
> >  	struct amdgpu_device *adev = dev->dev_private;
> >  	struct drm_audio_component *acomp = data;
> >  
> > +	if (!device_link_add(hda_kdev, kdev, DL_FLAG_STATELESS |
> > +			     DL_FLAG_PM_RUNTIME)) {
> > +		DRM_ERROR("DM: cannot add device link to audio device\n");
> > +		return -ENOMEM;
> > +	}
> > +
> 
> Doesn't this duplicate drivers/pci/quirks.c:quirk_gpu_hda() ?

Gah, you're right, that was the place I overlooked.
It was a typical "false Eureka right-after-wakeup" phenomenon :)
Need a vaccine aka coffee...

So the runtime PM dependency must be already placed there, and the
problem is not the lack of the dependency tree but the really other
timing issue.  Back to square.


thanks,

Takashi