lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 May 2020 00:03:26 +0900 From: Masahiro Yamada <masahiroy@...nel.org> To: Siddharth Gupta <sidgup@...eaurora.org> Cc: Sam Ravnborg <sam@...nborg.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [PATCH] scripts: headers_install: Exit with error on config leak On Sat, May 2, 2020 at 6:55 AM Siddharth Gupta <sidgup@...eaurora.org> wrote: > > Misuse of CONFIG_* in UAPI headers should result in an error as it exposes > configuration of different targets to userspace. > > Signed-off-by: Siddharth Gupta <sidgup@...eaurora.org> > --- > scripts/headers_install.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/headers_install.sh b/scripts/headers_install.sh > index a07668a..bd6c93a 100755 > --- a/scripts/headers_install.sh > +++ b/scripts/headers_install.sh > @@ -109,7 +109,8 @@ do > done > > if [ "$warn" = 1 ]; then > - echo "warning: $INFILE: leak $c to user-space" >&2 > + echo "error: $INFILE: leak $c to user-space" >&2 > + exit 1 > fi > done If you want to change this, please update the comment at line 67. Also, rename the variable $warn to something else, $error or $leak_error, etc. ? -- Best Regards Masahiro Yamada
Powered by blists - more mailing lists