lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 2 May 2020 21:40:24 +0200 From: Markus Elfring <Markus.Elfring@....de> To: Wang YanQing <udknight@...il.com>, Joe Perches <joe@...ches.com>, Andy Whitcroft <apw@...onical.com>, kernel-janitors@...r.kernel.org, linux-doc@...r.kernel.org Cc: linux-kernel@...r.kernel.org, Alexei Starovoitov <alexei.starovoitov@...il.com>, Matteo Croce <mcroce@...hat.com> Subject: Re: [PATCH v4] checkpatch: add support to check 'Fixes:' tag format > The check doesn't support below formats and it will emit diagnostics info for them: … > Fixes: ba35f8588f47 (“ipvlan: Defer multicast / broadcast processing to a work-queue”) … > Fixes: 03f6fc6de919 ('ASoC: rt5682: Add the soundwire support') Will the tolerance (and support) grow for such quotation character alternatives? > Note: this patch also fixes double quotation mark issue for normal git > commit description, and now it supports double quotation mark in > title line, for example: > Commit e33e2241e272 ("Revert "cfg80211: Use 5MHz bandwidth by default > when checking usable channels"") Do you care to achieve a safe data format description also for this use case? > Note: this patch also adds diagnostics info support for normal git commit > description format check. Does this information indicate a need to split possible changes into separate update steps? > + $diagnostics .= "Missing a pair of parentheses '()' or a pair of double quotation marks (\"\").\n"; Can such a message trigger any more thoughts and development ideas? > + $diagnostics .= "The title is too abbreviated, at least half of orignial commit title is necessary.\n"; * Please avoid a typo in this message. * Which formula do you propose for the length calculation? Regards, Markus
Powered by blists - more mailing lists