lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 1 May 2020 17:25:05 -0700 From: Bart Van Assche <bvanassche@....org> To: Luis Chamberlain <mcgrof@...nel.org>, axboe@...nel.dk, viro@...iv.linux.org.uk, gregkh@...uxfoundation.org, rostedt@...dmis.org, mingo@...hat.com, jack@...e.cz, ming.lei@...hat.com, nstange@...e.de, akpm@...ux-foundation.org Cc: mhocko@...e.com, yukuai3@...wei.com, linux-block@...r.kernel.org, linux-fsdevel@...r.kernel.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH v3 3/6] blktrace: move blktrace debugfs creation to helper function On 2020-04-29 00:46, Luis Chamberlain wrote: > +static struct dentry *blk_trace_debugfs_dir(struct blk_user_trace_setup *buts, > + struct blk_trace *bt) > +{ > + struct dentry *dir = NULL; > + > + dir = debugfs_lookup(buts->name, blk_debugfs_root); > + if (!dir) > + bt->dir = dir = debugfs_create_dir(buts->name, blk_debugfs_root); > + > + return dir; > +} Initializing 'dir' is not necessary since the first statement overwrites 'dir'. Anyway: Reviewed-by: Bart Van Assche <bvanassche@....org>
Powered by blists - more mailing lists