linux-kernel - Re: [PATCH] iio: adc: ad7768-1: Fix channel endian spec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200503124211.41933e29@archlinux>
Date:   Sun, 3 May 2020 12:42:11 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Sergiu Cuciurean <sergiu.cuciurean@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <knaack.h@....de>, <Michael.Hennerich@...log.com>
Subject: Re: [PATCH] iio: adc: ad7768-1: Fix channel endian spec

On Wed, 29 Apr 2020 13:45:35 +0300
Sergiu Cuciurean <sergiu.cuciurean@...log.com> wrote:

> This change removes the endian description from the iio channel spec.
> In this way, the default (IIO_CPU) endian will be used, matching the
> be32_to_cpu() conversion from ad7768_spi_reg_read().
> 
> Fixes: 8a15c73a9bcfe ("iio: adc: Add AD7768-1 ADC basic support")
> 
> Signed-off-by: Sergiu Cuciurean <sergiu.cuciurean@...log.com>

Hi Sergiu,

The endian marking only applies to the push_to_buffers data.  That
is read from the hardware using spi_read, not the ad7768_spi_reg_read
function.  So logic above doesn't hold.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/ad7768-1.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c
> index a0027797a7fe..99da13c3511a 100644
> --- a/drivers/iio/adc/ad7768-1.c
> +++ b/drivers/iio/adc/ad7768-1.c
> @@ -144,7 +144,6 @@ static const struct iio_chan_spec ad7768_channels[] = {
>  			.realbits = 24,
>  			.storagebits = 32,
>  			.shift = 8,
> -			.endianness = IIO_BE,
>  		},
>  	},
>  };