linux-kernel - Re: [PATCH] rtc: mc13xxx: fix a double-unlock issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <b9c82115-c70a-2381-f920-385846eb2a45@web.de>
Date:   Sun, 3 May 2020 14:05:41 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Qiushi Wu <wu000273@....edu>, linux-rtc@...r.kernel.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Kangjie Lu <kjlu@....edu>
Subject: Re: [PATCH] rtc: mc13xxx: fix a double-unlock issue

> … To fix this problem,
> we need to call mc13xxx_lock() again in this error path.

How do you think about a wording variant like the following?

   Change description:
   …
   Thus add a call of the function “mc13xxx_lock” in an if branch
   for the completion of the exception handling.


Would you like to add the tag “Fixes”?

Regards,
Markus