[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200503040056.29683-1-changbin.du@gmail.com>
Date: Sun, 3 May 2020 04:00:56 +0000
From: Changbin Du <changbin.du@...il.com>
To: Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Jiri Olsa <jolsa@...hat.com>
Cc: linux-kernel@...r.kernel.org, Changbin Du <changbin.du@...il.com>
Subject: [PATCH] perf trace: add default value for opt 'call-graph'
The documentation says the default value of call-graph.record_mode is 'fp'.
But actually we never can omit value of call-graph parameter. This patch
can fix this issue.
Meanwhile, this patch adds a short name '-g' for opt 'call-graph' since it's
very useful.
Signed-off-by: Changbin Du <changbin.du@...il.com>
---
tools/perf/builtin-trace.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/tools/perf/builtin-trace.c b/tools/perf/builtin-trace.c
index 01d542007c8b..21a9656021a0 100644
--- a/tools/perf/builtin-trace.c
+++ b/tools/perf/builtin-trace.c
@@ -4754,9 +4754,9 @@ int cmd_trace(int argc, const char **argv)
"Trace pagefaults", parse_pagefaults, "maj"),
OPT_BOOLEAN(0, "syscalls", &trace.trace_syscalls, "Trace syscalls"),
OPT_BOOLEAN('f', "force", &trace.force, "don't complain, do it"),
- OPT_CALLBACK(0, "call-graph", &trace.opts,
+ OPT_CALLBACK_DEFAULT('g', "call-graph", &trace.opts,
"record_mode[,record_size]", record_callchain_help,
- &record_parse_callchain_opt),
+ &record_parse_callchain_opt, "fp"),
OPT_BOOLEAN(0, "libtraceevent_print", &trace.libtraceevent_print,
"Use libtraceevent to print the tracepoint arguments."),
OPT_BOOLEAN(0, "kernel-syscall-graph", &trace.kernel_syscallchains,
--
2.17.1
Powered by blists - more mailing lists