linux-kernel - Re: [PATCH 03/33] efi/libstub: Unify EFI call wrappers for non-x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200503160943.GA718804@rani.riverdale.lan>
Date:   Sun, 3 May 2020 12:09:43 -0400
From:   Arvind Sankar <nivedita@...m.mit.edu>
To:     Guenter Roeck <linux@...ck-us.net>
Cc:     Ard Biesheuvel <ardb@...nel.org>, linux-efi@...r.kernel.org,
        Ingo Molnar <mingo@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-kernel@...r.kernel.org,
        Arvind Sankar <nivedita@...m.mit.edu>,
        Atish Patra <atish.patra@....com>,
        Palmer Dabbelt <palmerdabbelt@...gle.com>,
        Zou Wei <zou_wei@...wei.com>
Subject: Re: [PATCH 03/33] efi/libstub: Unify EFI call wrappers for non-x86

On Sun, May 03, 2020 at 08:09:06AM -0700, Guenter Roeck wrote:
> Hi,
> 
> On Fri, Apr 24, 2020 at 03:05:01PM +0200, Ard Biesheuvel wrote:
> > We have wrappers around EFI calls so that x86 can define special
> > versions for mixed mode, while all other architectures can use the
> > same simple definition that just issues the call directly.
> > In preparation for the arrival of yet another architecture that doesn't
> > need anything special here (RISC-V), let's move the default definition
> > into a shared header.
> > 
> > Signed-off-by: Ard Biesheuvel <ardb@...nel.org>
> 
> This patch causes an immediate reboot in linux-next when booting
> in qemu with an efi32 bios. Bisect log attached.
> 
> Qemu command line:
> 
> qemu-system-x86_64 -kernel arch/x86/boot/bzImage -m 1G \
> 	-no-reboot -snapshot \
> 	-bios OVMF-pure-efi-32.fd \
> 	-drive file=rootfs.ext2,format=raw \
> 	--append 'earlycon=uart8250,io,0x3f8,9600n8 panic=-1 root=/dev/sda console=ttyS0' \
> 	-nographic
> 
> The same command succeeds with OVMF-pure-efi-64.fd.
> 
> Bisect log attached.
> 
> File locations:
> 	https://github.com/groeck/linux-build-test/blob/master/rootfs/firmware/OVMF-pure-efi-32.fd
> 	https://github.com/groeck/linux-build-test/blob/master/rootfs/x86_64/rootfs.ext2.gz
> 
> Guenter
> 

The issue is that efi_is_native is an inline function on x86, not a
macro, so the #ifndef efi_is_native is broken.

We can either turn it into a macro, or add
	#define efi_is_native efi_is_native
in arch/x86/include/asm/efi.h.