linux-kernel - Re: [PATCH] i2c: img-scb: Use devm_platform_ioremap_resource and remove superfluous error message.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sun, 3 May 2020 19:28:07 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Aishwarya Ramakrishnan <aishwaryarj100@...il.com>
Cc:     Brendan Higgins <brendanhiggins@...gle.com>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Allison Randal <allison@...utok.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-i2c <linux-i2c@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] i2c: img-scb: Use devm_platform_ioremap_resource and
 remove superfluous error message.

On Sun, May 3, 2020 at 4:13 PM Aishwarya Ramakrishnan
<aishwaryarj100@...il.com> wrote:
>
> Use the helper function that wraps the calls to
> platform_get_resource() and devm_ioremap_resource()
> together.
>
> The function platform_get_irq can log an error by itself.
> Omit a redundant message for exception handling in the
> calling function.
>
> Suggested by coccinelle.

Should be two patches, each of which with an explanation given. (And
of course you have to mention after cutter line '---' what kind of
tests you performed?)

-- 
With Best Regards,
Andy Shevchenko