linux-kernel - Re: [PATCH] dt-bindings: net: add IPA iommus property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <040dbe54-1a64-6d32-076e-189963f10036@linaro.org>
Date:   Mon, 4 May 2020 13:23:16 -0500
From:   Alex Elder <elder@...aro.org>
To:     robh+dt@...nel.org, bjorn.andersson@...aro.org, agross@...nel.org
Cc:     evgreen@...omium.org.net, subashab@...eaurora.org,
        cpratapa@...eaurora.org, davem@...emloft.net,
        devicetree@...r.kernel.org, netdev@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: net: add IPA iommus property

On 5/1/20 4:45 PM, Alex Elder wrote:
> The IPA accesses "IMEM" and main system memory through an SMMU, so
> its DT node requires an iommus property to define range of stream IDs
> it uses.
> 
> Signed-off-by: Alex Elder <elder@...aro.org>

Please ignore this patch.  I have reposted it as the first
patch in a new series:
   https://lore.kernel.org/netdev/20200504175859.22606-1-elder@linaro.org/

					-Alex

> ---
>   Documentation/devicetree/bindings/net/qcom,ipa.yaml | 10 +++++++++-
>   1 file changed, 9 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/net/qcom,ipa.yaml b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> index 140f15245654..7b749fc04c32 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ipa.yaml
> @@ -20,7 +20,10 @@ description:
>     The GSI is an integral part of the IPA, but it is logically isolated
>     and has a distinct interrupt and a separately-defined address space.
>   
> -  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.
> +  See also soc/qcom/qcom,smp2p.txt and interconnect/interconnect.txt.  See
> +  iommu/iommu.txt and iommu/arm,smmu.yaml for more information about SMMU
> +  bindings.
> +
>   
>     - |
>       --------             ---------
> @@ -54,6 +57,9 @@ properties:
>         - const: ipa-shared
>         - const: gsi
>   
> +  iommus:
> +    maxItems: 1
> +
>     clocks:
>       maxItems: 1
>   
> @@ -126,6 +132,7 @@ properties:
>   
>   required:
>     - compatible
> +  - iommus
>     - reg
>     - clocks
>     - interrupts
> @@ -164,6 +171,7 @@ examples:
>                   modem-init;
>                   modem-remoteproc = <&mss_pil>;
>   
> +                iommus = <&apps_smmu 0x720 0x3>;
>                   reg = <0 0x1e40000 0 0x7000>,
>                           <0 0x1e47000 0 0x2000>,
>                           <0 0x1e04000 0 0x2c000>;
>