linux-kernel - Re: [v2 PATCH 1/2] drivers: drm: panel: Add ASUS TM5P5 NT35596 panel driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 4 May 2020 12:56:43 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Konrad Dybcio <konradybcio@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        dri-devel@...ts.freedesktop.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [v2 PATCH 1/2] drivers: drm: panel: Add ASUS TM5P5 NT35596 panel
 driver

On 5/4/20 12:38 PM, Konrad Dybcio wrote:
> diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig
> index a1723c1b5fbf8..3aa57a927c4bd 100644
> --- a/drivers/gpu/drm/panel/Kconfig
> +++ b/drivers/gpu/drm/panel/Kconfig
> @@ -18,6 +18,16 @@ config DRM_PANEL_ARM_VERSATILE
>  	  reference designs. The panel is detected using special registers
>  	  in the Versatile family syscon registers.
>  
> +config DRM_PANEL_ASUS_Z00T_TM5P5_NT35596
> +        tristate "ASUS Z00T TM5P5 NT35596 panel"
> +        depends on GPIOLIB && OF
> +        depends on DRM_MIPI_DSI
> +	depends on BACKLIGHT_CLASS_DEVICE
> +        help
> +          Say Y here if you want to enable support for the ASUS TMP5P5
> +          NT35596 1080x1920 video mode panel as found in some Asus
> +          Zenfone 2 Laser Z00T devices.
> +
>  config DRM_PANEL_BOE_HIMAX8279D
>  	tristate "Boe Himax8279d panel"
>  	depends on OF

Hi,

Please clean up the config entry indentation.
The keywords (tristate, depends, help) should all be indented with
one tab (not spaces) and the help text should be indented with
one tab + 2 spaces.

thanks.
-- 
~Randy