linux-kernel - Re: [PATCH] dmaengine: qcom_hidma: use true,false for bool variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 May 2020 16:02:58 -0400
From:   Sinan Kaya <okaya@...nel.org>
To:     Jason Yan <yanaijie@...wei.com>, agross@...nel.org,
        bjorn.andersson@...aro.org, vkoul@...nel.org,
        dan.j.williams@...el.com, linux-arm-kernel@...ts.infradead.org,
        linux-arm-msm@...r.kernel.org, dmaengine@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dmaengine: qcom_hidma: use true,false for bool variable

On 5/4/2020 7:34 AM, Jason Yan wrote:
> Fix the following coccicheck warning:
> 
> drivers/dma/qcom/hidma.c:553:1-17: WARNING: Assignment of 0/1 to bool
> variable
> 
> Signed-off-by: Jason Yan <yanaijie@...wei.com>
> ---
>  drivers/dma/qcom/hidma.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c
> index 87490e125bc3..0a6d3ea08c78 100644
> --- a/drivers/dma/qcom/hidma.c
> +++ b/drivers/dma/qcom/hidma.c
> @@ -550,7 +550,7 @@ static void hidma_free_chan_resources(struct dma_chan *dmach)
>  		kfree(mdesc);
>  	}
>  
> -	mchan->allocated = 0;
> +	mchan->allocated = false;
>  	spin_unlock_irqrestore(&mchan->lock, irqflags);
>  }

Acked By: Sinan Kaya <okaya@...nel.org>