[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20200504094253.2741109-1-noltari@gmail.com>
Date: Mon, 4 May 2020 11:42:53 +0200
From: Álvaro Fernández Rojas
<noltari@...il.com>
To: miquel.raynal@...tlin.com, richard@....at, vigneshr@...com,
s.hauer@...gutronix.de, masonccyang@...c.com.tw,
boris.brezillon@...labora.com, christophe.kerello@...com,
stefan@...er.ch, piotrs@...ence.com, devik@...labs.cz,
tglx@...utronix.de, linux-mtd@...ts.infradead.org,
linux-kernel@...r.kernel.org
Cc: Álvaro Fernández Rojas
<noltari@...il.com>
Subject: [PATCH] nand: raw: use write_oob_raw for MTD_OPS_AUTO_OOB mode
Some NAND controllers change the ECC bytes when OOB is written with ECC
enabled.
This is a problem in brcmnand, since adding JFFS2 cleanmarkers after the page
has been erased will change the ECC bytes to 0 and the controller will think
the block is bad.
It can be fixed by using write_oob_raw, which ensures ECC is disabled.
Signed-off-by: Álvaro Fernández Rojas <noltari@...il.com>
---
drivers/mtd/nand/raw/nand_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/raw/nand_base.c b/drivers/mtd/nand/raw/nand_base.c
index c24e5e2ba130..755d25200520 100644
--- a/drivers/mtd/nand/raw/nand_base.c
+++ b/drivers/mtd/nand/raw/nand_base.c
@@ -488,7 +488,7 @@ static int nand_do_write_oob(struct nand_chip *chip, loff_t to,
nand_fill_oob(chip, ops->oobbuf, ops->ooblen, ops);
- if (ops->mode == MTD_OPS_RAW)
+ if (ops->mode == MTD_OPS_AUTO_OOB || ops->mode == MTD_OPS_RAW)
status = chip->ecc.write_oob_raw(chip, page & chip->pagemask);
else
status = chip->ecc.write_oob(chip, page & chip->pagemask);
--
2.26.2
Powered by blists - more mailing lists