[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20200504095042.4289CC432C2@smtp.codeaurora.org>
Date: Mon, 4 May 2020 09:50:42 +0000 (UTC)
From: Kalle Valo <kvalo@...eaurora.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Arend van Spriel <arend.vanspriel@...adcom.com>,
Franky Lin <franky.lin@...adcom.com>,
Hante Meuleman <hante.meuleman@...adcom.com>,
Chi-Hsien Lin <chi-hsien.lin@...ress.com>,
Wright Feng <wright.feng@...ress.com>,
"David S. Miller" <davem@...emloft.net>,
Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Rafał Miłecki <rafal@...ecki.pl>,
linux-wireless@...r.kernel.org,
brcm80211-dev-list.pdl@...adcom.com,
brcm80211-dev-list@...ress.com, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] brcmfmac: no need to check return value of debugfs_create
functions
Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote:
> When calling debugfs functions, there is no need to ever check the
> return value. The function can work or not, but the code logic should
> never do something different based on this.
>
> In doing this, make brcmf_debugfs_add_entry() return void as no one was
> even paying attention to the return value.
>
> Cc: Arend van Spriel <arend.vanspriel@...adcom.com>
> Cc: Franky Lin <franky.lin@...adcom.com>
> Cc: Hante Meuleman <hante.meuleman@...adcom.com>
> Cc: Chi-Hsien Lin <chi-hsien.lin@...ress.com>
> Cc: Wright Feng <wright.feng@...ress.com>
> Cc: Kalle Valo <kvalo@...eaurora.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Pieter-Paul Giesberts <pieter-paul.giesberts@...adcom.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: "Rafał Miłecki" <rafal@...ecki.pl>
> Cc: linux-wireless@...r.kernel.org
> Cc: brcm80211-dev-list.pdl@...adcom.com
> Cc: brcm80211-dev-list@...ress.com
> Cc: netdev@...r.kernel.org
> Cc: linux-kernel@...r.kernel.org
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Acked-by: Arend van Spriel <arend.vanspriel@...adcom.com>
Patch applied to wireless-drivers-next.git, thanks.
ea1b3bc6d5ad brcmfmac: no need to check return value of debugfs_create functions
--
https://patchwork.kernel.org/patch/11516617/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists