linux-kernel - Re: [PATCH 6/6] mfd: lochnagar: Move binding over to dtschema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 4 May 2020 09:55:08 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Rob Herring <robh@...nel.org>
CC:     <lee.jones@...aro.org>, <broonie@...nel.org>,
        <mturquette@...libre.com>, <sboyd@...nel.org>, <jdelvare@...e.com>,
        <linux@...ck-us.net>, <linus.walleij@...aro.org>,
        <lgirdwood@...il.com>, <linux-kernel@...r.kernel.org>,
        <devicetree@...r.kernel.org>, <patches@...nsource.cirrus.com>
Subject: Re: [PATCH 6/6] mfd: lochnagar: Move binding over to dtschema

On Fri, May 01, 2020 at 03:47:21PM -0500, Rob Herring wrote:
> On Mon, Apr 27, 2020 at 10:36:14AM +0000, Charles Keepax wrote:
> > On Mon, Apr 27, 2020 at 11:28:12AM +0100, Charles Keepax wrote:
> > > Signed-off-by: Charles Keepax <ckeepax@...nsource.cirrus.com>
> > > ---
> > > +            lochnagar-pinctrl {
> > > +                compatible = "cirrus,lochnagar-pinctrl";
> > > +
> > > +                gpio-controller;
> > > +                #gpio-cells = <2>;
> > > +                gpio-ranges = <&lochnagar 0 0 LOCHNAGAR2_PIN_NUM_GPIOS>;
> > > +
> > > +                pinctrl-names = "default";
> > > +                pinctrl-0 = <&pinsettings>;
> > 
> > This seems to cause the following error:
> > 
> > Documentation/devicetree/bindings/mfd/cirrus,lochnagar.example.dt.yaml:
> > lochnagar@22: lochnagar-pinctrl:pin-settings:phandle: [[4]] is not of type 'object'
> > 
> > I think the schema is correct and the problem is one of tooling,
> > I have been poking at it for a while but can't seem to find a way
> > to silence this one. Any advice would be greatly appreciated.
> 
> The problem is the "^.*$" patterns to match child node names also match 
> properties like 'phandle'. Ideally, you'd have some pattern to match on 
> for the node names.
> 
> There is work-around doing:
> 
> "^.*$":
>   if:
>     type: object
>   then:
>     properties:
>       ...
> 

I believe I did try this and run into some other problems.

> But I much prefer to see node names updated. '-pins$' is a common 
> pattern.
> 

I have no problem requiring a pins suffix on the sub-nodes. Will
add that and send a new version, fixing up your other comments as
well. Thank you for your suggestions and review.

Thanks,
Charles