linux-kernel - Re: [PATCH] i2c: cht-wc: Remove superfluous error message in cht_wc_i2c_adap_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0605496b-d4f1-c87c-5b45-699c8c3dcaec@redhat.com>
Date:   Mon, 4 May 2020 12:00:55 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Aishwarya Ramakrishnan <aishwaryarj100@...il.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: cht-wc: Remove superfluous error message in
 cht_wc_i2c_adap_i2c_probe()

Hi,

On 5/3/20 3:23 PM, Aishwarya Ramakrishnan wrote:
> The function platform_get_irq can log an error by itself.
> This omit a redundant message for exception handling in the
> calling function.
> 
> Suggested by Coccinelle.
> 
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@...il.com>

Thank you for the patch, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans



> ---
>   drivers/i2c/busses/i2c-cht-wc.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-cht-wc.c b/drivers/i2c/busses/i2c-cht-wc.c
> index 35e55feda763..343ae5754e6e 100644
> --- a/drivers/i2c/busses/i2c-cht-wc.c
> +++ b/drivers/i2c/busses/i2c-cht-wc.c
> @@ -314,10 +314,8 @@ static int cht_wc_i2c_adap_i2c_probe(struct platform_device *pdev)
>   	int ret, reg, irq;
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(&pdev->dev, "Error missing irq resource\n");
> +	if (irq < 0)
>   		return -EINVAL;
> -	}
>   
>   	adap = devm_kzalloc(&pdev->dev, sizeof(*adap), GFP_KERNEL);
>   	if (!adap)
>