linux-kernel - Re: [PATCH] i2c: drivers: Remove superfluous error messages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 4 May 2020 14:30:22 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Aishwarya Ramakrishnan <aishwaryarj100@...il.com>,
        linux-i2c@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Baruch Siach <baruch@...s.co.il>,
        Dejin Zheng <zhengdejin5@...il.com>,
        Dmitry Osipenko <digetx@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Gregory Clement <gregory.clement@...tlin.com>,
        Hans de Goede <hdegoede@...hat.com>,
        Masahiro Yamada <yamada.masahiro@...ionext.com>,
        Pierre-Yves Mordret <pierre-yves.mordret@...com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Thor Thayer <thor.thayer@...ux.intel.com>,
        Vladimir Zapolskiy <vz@...ia.com>
Subject: Re: [PATCH] i2c: drivers: Remove superfluous error messages

> The function platform_get_irq can log an error by itself.
> This omit a redundant message for exception handling in the
> calling function.

I propose to avoid a typo in a word of this change description.


> Suggested by Coccinelle.

Can an information like the following be more helpful?

Generated by: scripts/coccinelle/api/platform_get_irq.cocci


I observe that a command like “make COCCI=… M=drivers/i2c/busses/ coccicheck”
points only three source files out for further considerations
according to such a known transformation pattern in the software “Linux next-20200504”.

Regards,
Markus