linux-kernel - Re: [PATCH] i2c: altera: Remove superfluous error message in altr_i2c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d8dd2831-c067-61f1-d76f-aec9c86f21b6@linux.intel.com>
Date:   Mon, 4 May 2020 09:10:10 -0500
From:   Thor Thayer <thor.thayer@...ux.intel.com>
To:     Aishwarya Ramakrishnan <aishwaryarj100@...il.com>,
        linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: altera: Remove superfluous error message in
 altr_i2c_probe()

On 5/3/20 7:48 AM, Aishwarya Ramakrishnan wrote:
> The function platform_get_irq can log an error by itself.
> This omit a redundant message for exception handling in the
> calling function.
> 
> Suggested by Coccinelle.
> 
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@...il.com>
> ---
>   drivers/i2c/busses/i2c-altera.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-altera.c b/drivers/i2c/busses/i2c-altera.c
> index f5c00f903df3..af6985f0ae63 100644
> --- a/drivers/i2c/busses/i2c-altera.c
> +++ b/drivers/i2c/busses/i2c-altera.c
> @@ -395,10 +395,8 @@ static int altr_i2c_probe(struct platform_device *pdev)
>   		return PTR_ERR(idev->base);
>   
>   	irq = platform_get_irq(pdev, 0);
> -	if (irq < 0) {
> -		dev_err(&pdev->dev, "missing interrupt resource\n");
> +	if (irq < 0)
>   		return irq;
> -	}
>   
>   	idev->i2c_clk = devm_clk_get(&pdev->dev, NULL);
>   	if (IS_ERR(idev->i2c_clk)) {
> 

Reviewed-by: Thor Thayer <thor.thayer@...ux.intel.com>