linux-kernel - Re: [PATCH] net: enetc: fix an issue about leak system resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <9de14fae-458f-adb7-a5e7-5beb05d8d9ea@web.de>
Date:   Mon, 4 May 2020 16:12:11 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>, netdev@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Claudiu Manoil <claudiu.manoil@....com>,
        "David S. Miller" <davem@...emloft.net>,
        Vladimir Oltean <vladimir.oltean@....com>
Subject: Re: [PATCH] net: enetc: fix an issue about leak system resources

> the related system resources were not released when enetc_hw_alloc()
> return error in the enetc_pci_mdio_probe(), add iounmap() for error
> handling label "err_hw_alloc" to fix it.

How do you think about a wording variant like the following?

   Subject:
   [PATCH v2] net: enetc: Complete exception handling in enetc_pci_mdio_probe()

   Change description:
   A call of the function “enetc_hw_alloc” can fail here.
   The corresponding system resources were not released then.
   Thus move a call of the function “iounmap” behind
   the label “err_hw_alloc”.

Would you like to reduce the labels for this function implementation instead?

Regards,
Markus