linux-kernel - Re: [PATCH v12 2/5] usb: renesas-xhci: Add the renesas xhci driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200504143438.GT1375924@vkoul-mobl>
Date:   Mon, 4 May 2020 20:04:38 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Mathias Nyman <mathias.nyman@...ux.intel.com>
Cc:     Mathias Nyman <mathias.nyman@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-arm-msm@...r.kernel.org,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Christian Lamparter <chunkeey@...glemail.com>,
        Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>,
        John Stultz <john.stultz@...aro.org>,
        Alan Stern <stern@...land.harvard.edu>,
        Andreas Böhler <dev@...ehler.at>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v12 2/5] usb: renesas-xhci: Add the renesas xhci driver

Hi Mathias,

On 04-05-20, 16:01, Mathias Nyman wrote:
> On 30.4.2020 19.59, Vinod Koul wrote:
> > From: Christian Lamparter <chunkeey@...glemail.com>
> > 
> > This add a new driver for renesas xhci which is basically a firmware
> > loader for uPD720201 and uPD720202 w/o ROM. The xhci-pci driver will
> > invoke this driver for loading/unloading on relevant devices.
> > 
> > This patch adds a firmware loader for the uPD720201K8-711-BAC-A
> > and uPD720202K8-711-BAA-A variant. Both of these chips are listed
> > in Renesas' R19UH0078EJ0500 Rev.5.00 "User's Manual: Hardware" as
> > devices which need the firmware loader on page 2 in order to
> > work as they "do not support the External ROM".
> > 
> > The "Firmware Download Sequence" is describe in chapter
> > "7.1 FW Download Interface" R19UH0078EJ0500 Rev.5.00 page 131.
> > 
> > The firmware "K2013080.mem" is available from a USB3.0 Host to
> > PCIe Adapter (PP2U-E card) "Firmware download" archive. An
> > alternative version can be sourced from Netgear's WNDR4700 GPL
> > archives.
> > 
> > The release notes of the PP2U-E's "Firmware Download" ver 2.0.1.3
> > (2012-06-15) state that the firmware is for the following devices:
> >  - uPD720201 ES 2.0 sample whose revision ID is 2.
> >  - uPD720201 ES 2.1 sample & CS sample & Mass product, ID is 3.
> >  - uPD720202 ES 2.0 sample & CS sample & Mass product, ID is 2.
> > 
> > Signed-off-by: Christian Lamparter <chunkeey@...glemail.com>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > [vkoul: fixed comments:
> > 	used macros for timeout count and delay
> > 	removed renesas_fw_alive_check
> > 	cleaned renesas_fw_callback
> > 	removed recursion for renesas_fw_download
> > 	add register defines and field names
> > 	move to a separate file
> > 	make fw loader as sync probe so that we execute in probe and
> >         prevent race
> > 	export symbols for xhci-pci to use]
> > Signed-off-by: Vinod Koul <vkoul@...nel.org>
> > ---
> >  drivers/usb/host/Makefile           |   2 +-
> >  drivers/usb/host/xhci-pci-renesas.c | 365 ++++++++++++++++++++++++++++
> >  drivers/usb/host/xhci-pci.h         |  16 ++
> >  3 files changed, 382 insertions(+), 1 deletion(-)
> >  create mode 100644 drivers/usb/host/xhci-pci-renesas.c
> >  create mode 100644 drivers/usb/host/xhci-pci.h
> > 
> > diff --git a/drivers/usb/host/Makefile b/drivers/usb/host/Makefile
> > index b191361257cc..f3a5a2f01874 100644
> > --- a/drivers/usb/host/Makefile
> > +++ b/drivers/usb/host/Makefile
> > @@ -70,7 +70,7 @@ obj-$(CONFIG_USB_OHCI_HCD_DAVINCI)	+= ohci-da8xx.o
> >  obj-$(CONFIG_USB_UHCI_HCD)	+= uhci-hcd.o
> >  obj-$(CONFIG_USB_FHCI_HCD)	+= fhci.o
> >  obj-$(CONFIG_USB_XHCI_HCD)	+= xhci-hcd.o
> > -obj-$(CONFIG_USB_XHCI_PCI)	+= xhci-pci.o
> > +obj-$(CONFIG_USB_XHCI_PCI)	+= xhci-pci.o xhci-pci-renesas.o
> 
> Hmm, now we end up with two modules, xhci-pci and xhci-pci-renesas, even if
> xhci-pci-renesas just includes helper functions to load firmware for renesas.

Right, these are two modules. Do you forsee an issue with two ko's
> 
> My kbuild knowledge is limited, but one way to solve this would be to 
> rename xhci-pci.c to xhci-pci-core.c and add:

Yeah i wanted to avoid the rename (stopped short of suggesting that)..
> 
> xhci-pci-y := xhci-pci-core.o xhci-pci-renesas.o
> 
> unless someone can suggest a better way to solve this

I dont have any better idea atm!

So if you are okay with rename of file, I can do that first and then
these patches

Thanks
-- 
~Vinod