linux-kernel - Re: [PATCH] net: rtw88: fix an issue about leak system resources

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <882eacd1-1cbf-6aef-06c5-3ed6d402c0f5@web.de>
Date:   Mon, 4 May 2020 17:00:40 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org
Cc:     LKML <linux-kernel@...r.kernel.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Brian Norris <briannorris@...omium.org>,
        "David S. Miller" <davem@...emloft.net>,
        Kalle Valo <kvalo@...eaurora.org>,
        Stanislaw Gruszka <sgruszka@...hat.com>,
        Yan-Hsuan Chuang <yhchuang@...ltek.com>
Subject: Re: [PATCH] net: rtw88: fix an issue about leak system resources

>>> the related system resources were not released when pci_iomap() return
>>> error in the rtw_pci_io_mapping() function. add pci_release_regions() to
>>> fix it.
>>
>> How do you think about a wording variant like the following?
>>
>>    Subject:
>>    [PATCH v2] net: rtw88: Complete exception handling in rtw_pci_io_mapping()
>>
>>    Change description:
>>    A call of the function “pci_request_regions” can fail here.
>>    The corresponding system resources were not released then.
>>    Thus add a call of the function “pci_release_regions”.
>>
>>
> Markus, I think my commit comments is a sufficiently clear description
> for this patch.

I got an other impression for specific aspects.


> Someone has told me not to send commit comments again and again
> when it is enough clear.

My patch review tries should give you hints where I noticed wording weaknesses.
The corresponding change tolerance can vary by involved contributors.


> Because it only wastes the precious time of the maintainer
> and very very little help for patch improvement.

I hope that also your commit messages will improve.


> BTW, In the past week, you asked me to change the commit comments in my
> 6 patches like this one. Let me return to the essence of patch, point
> out the code problems and better solutions will be more popular.

I would appreciate if various update suggestions would become nicer somehow.

Regards,
Markus