linux-kernel - Re: [PATCH 00/10] KVM: x86: Misc anti-retpoline optimizations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200504150940.GB16949@linux.intel.com>
Date:   Mon, 4 May 2020 08:09:40 -0700
From:   Sean Christopherson <sean.j.christopherson@...el.com>
To:     Paolo Bonzini <pbonzini@...hat.com>
Cc:     Vitaly Kuznetsov <vkuznets@...hat.com>,
        Wanpeng Li <wanpengli@...cent.com>,
        Jim Mattson <jmattson@...gle.com>,
        Joerg Roedel <joro@...tes.org>, kvm@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/10] KVM: x86: Misc anti-retpoline optimizations

On Mon, May 04, 2020 at 03:25:58PM +0200, Paolo Bonzini wrote:
> On 02/05/20 06:32, Sean Christopherson wrote:
> > A smattering of optimizations geared toward avoiding retpolines, though
> > IMO most of the patches are worthwhile changes irrespective of retpolines.
> > I can split this up into separate patches if desired, outside of the
> > obvious combos there are no dependencies.
> 
> Most of them are good stuff anyway, I agree.
> 
> Since I like to believe that static calls _are_ close, I queued these:
> 
>       KVM: x86: Save L1 TSC offset in 'struct kvm_vcpu_arch'
>       KVM: nVMX: Unconditionally validate CR3 during nested transitions
>       KVM: VMX: Add proper cache tracking for CR4
>       KVM: VMX: Add proper cache tracking for CR0
>       KVM: VMX: Move nested EPT out of kvm_x86_ops.get_tdp_level() hook
>       KVM: x86/mmu: Capture TDP level when updating CPUID
> 
> and I don't disagree with the DR6 one though it can be even improved a
> bit so I'll send a patch myself.

Sounds good, thanks!