linux-kernel - Re: [PATCH v2] misc: new driver sram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202005042233.TRh5ui7l%lkp@intel.com>
Date:   Mon, 4 May 2020 22:51:55 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Wang Wenhu <wenhu.wang@...o.com>, gregkh@...uxfoundation.org,
        arnd@...db.de, linux-kernel@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, kernel@...o.com, robh@...nel.org,
        Christophe Leroy <christophe.leroy@....fr>,
        Scott Wood <oss@...error.net>,
        Michael Ellerman <mpe@...erman.id.au>,
        Randy Dunlap <rdunlap@...radead.org>
Cc:     kbuild-all@...ts.01.org, kernel@...o.com, robh@...nel.org,
        Wang Wenhu <wenhu.wang@...o.com>,
        Christophe Leroy <christophe.leroy@....fr>,
        Scott Wood <oss@...error.net>,
        Michael Ellerman <mpe@...erman.id.au>
Subject: Re: [PATCH v2] misc: new driver sram_uapi for user level SRAM access

Hi Wang,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on char-misc/char-misc-testing]
[also build test WARNING on arm-soc/for-next linus/master linux/master v5.7-rc3 next-20200501]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Wang-Wenhu/misc-new-driver-sram_uapi-for-user-level-SRAM-access/20200421-105427
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git ae83d0b416db002fe95601e7f97f64b59514d936
config: microblaze-allyesconfig (attached as .config)
compiler: microblaze-linux-gcc (GCC) 9.3.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day GCC_VERSION=9.3.0 make.cross ARCH=microblaze 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/misc/sram_uapi.c: In function 'sram_uapi_ioctl':
>> drivers/misc/sram_uapi.c:100:6: warning: 'type' may be used uninitialized in this function [-Wmaybe-uninitialized]
     100 |   if (cur->type == type) {
         |      ^
   drivers/misc/sram_uapi.c:188:8: note: 'type' was declared here
     188 |  __u32 type;
         |        ^~~~

vim +/type +100 drivers/misc/sram_uapi.c

    93	
    94	static struct sram_api *get_sram_api_from_type(__u32 type)
    95	{
    96		struct sram_api *cur;
    97	
    98		mutex_lock(&sram_list_lock);
    99		list_for_each_entry(cur, &sram_list, list) {
 > 100			if (cur->type == type) {
   101				kref_get(&cur->kref);
   102				mutex_unlock(&sram_list_lock);
   103				return cur;
   104			}
   105		}
   106		mutex_unlock(&sram_list_lock);
   107	
   108		return NULL;
   109	}
   110	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (62734 bytes)