linux-kernel - Re: [PATCH] net/mlx5: reduce stack usage in qp_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAK8P3a30Qe=_L0Ji9k14SwGEZAKUX5FJ5YsFACGz_X3oBSSNQQ@mail.gmail.com>
Date:   Mon, 4 May 2020 17:41:56 +0200
From:   Arnd Bergmann <arnd@...db.de>
To:     Leon Romanovsky <leon@...nel.org>
Cc:     Saeed Mahameed <saeedm@...lanox.com>,
        "David S. Miller" <davem@...emloft.net>,
        Moshe Shemesh <moshe@...lanox.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Networking <netdev@...r.kernel.org>,
        linux-rdma <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] net/mlx5: reduce stack usage in qp_read_field

On Sun, May 3, 2020 at 7:30 AM Leon Romanovsky <leon@...nel.org> wrote:
> On Thu, Apr 30, 2020 at 04:37:14PM +0200, Arnd Bergmann wrote:
> > On Thu, Apr 30, 2020 at 7:22 AM Leon Romanovsky <leon@...nel.org> wrote:
> >
> > While warning limit is generally 1024 bytes for 32-bit architectures,
> > and 2048 bytes fro 64-bit architectures,  we should probably
> > reduce the latter to something like 1280 bytes and fix up the
> > warnings that introduces.
>
> It a chicken and an egg problem, I tried to use default frame size, but
> the output of my kernel build was constantly flooded with those warnings
> and made hard to spot real issues in the code I developed.
>

When did you last try? I usually send patches whenever I see a new
warning, so there really shouldn't be any such warnings in the mainline
kernel except for cases where patches are still under discussion.

If you have a configuration in which you see lots of frame size warnings,
can you send me that .config file for that? It is possible that one or
more of the patches in my backlog fix a bunch of those issues
and need to be resent.

      Arnd