linux-kernel - Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200504154613.GA14031@alpha.franken.de>
Date:   Mon, 4 May 2020 17:46:13 +0200
From:   Thomas Bogendoerfer <tsbogend@...ha.franken.de>
To:     "Maciej W. Rozycki" <macro@...ux-mips.org>
Cc:     Jiaxun Yang <jiaxun.yang@...goat.com>, linux-mips@...r.kernel.org,
        clang-built-linux@...glegroups.com,
        Fangrui Song <maskray@...gle.com>,
        Kees Cook <keescook@...omium.org>,
        Nathan Chancellor <natechancellor@...il.com>,
        Paul Burton <paulburton@...nel.org>,
        Masahiro Yamada <masahiroy@...nel.org>,
        Jouni Hogander <jouni.hogander@...kie.com>,
        Kevin Darbyshire-Bryant <ldir@...byshire-bryant.me.uk>,
        Borislav Petkov <bp@...e.de>,
        Heiko Carstens <heiko.carstens@...ibm.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5] MIPS: Truncate link address into 32bit for 32bit
 kernel

On Fri, Apr 24, 2020 at 01:22:30PM +0100, Maciej W. Rozycki wrote:
> On Thu, 23 Apr 2020, Jiaxun Yang wrote:
> 
> > > Alternatively, have you made any attempt to verify if actually replacing 
> > >the setting for VMLINUX_LOAD_ADDRESS would be safe?  Glancing over its use 
> > >there do not appear to be many places.
> > 
> > Limited experiments showed it should be fine...
> > 
> > But MIPS kernel has some design I'm not really familiar with like SYM32 for
> > 64-bit kernel and special address space design for Trap-and-emul KVM.
> 
>  This only affects CONFIG_32BIT kernels, so SYM32 does not apply; I can't 
> comment on KVM.  There's still that bunch of:
> 
> $(shell expr $(...) \< 0xffffffff80000000)
> 
> constructs I mentioned before, so let's leave your change as it stands at 
> this time.  Please do rename the variable as I suggested though, I hope 
> that's not a big deal.

Jiaxun, are you going to send an update with this change ?

Thomas.

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]