linux-kernel - Re: [PATCH] drm/i915/gem: Fix inconsistent IS_ERR and PTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <dfe752dc-6833-2b08-7e7c-6c52ffc81626@web.de>
Date:   Mon, 4 May 2020 18:58:03 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>,
        dri-devel@...ts.freedesktop.org, intel-gfx@...ts.freedesktop.org
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        Chris Wilson <chris@...is-wilson.co.uk>,
        Daniel Vetter <daniel@...ll.ch>,
        David Airlie <airlied@...ux.ie>,
        Jani Nikula <jani.nikula@...ux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@...el.com>,
        Tvrtko Ursulin <tvrtko.ursulin@...el.com>
Subject: Re: [PATCH] drm/i915/gem: Fix inconsistent IS_ERR and PTR_ERR

…
> The proper pointer to be passed as argument is ce.
>
> This bug was detected with the help of Coccinelle.

My software development attention was caught also by your commit message.


…
> +++ b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c
> @@ -1325,7 +1325,7 @@ static int __reloc_gpu_alloc(struct i915_execbuffer *eb,
>
>  		ce = intel_context_create(engine);
>  		if (IS_ERR(ce)) {
> -			err = PTR_ERR(rq);
> +			err = PTR_ERR(ce);
>  			goto err_unpin;
>  		}
>

Are you looking for any more questionable identifier (or expression) combinations
also at other places by the means of advanced source code analysis?

Regards,
Markus