lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Tue, 5 May 2020 18:25:30 +0200
From:   Bartosz Golaszewski <bgolaszewski@...libre.com>
To:     Takashi Iwai <tiwai@...e.de>
Cc:     Linus Walleij <linus.walleij@...aro.org>,
        Kangjie Lu <kjlu@....edu>,
        linux-gpio <linux-gpio@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] gpio: exar: Fix bad handling for ida_simple_get error path

śr., 29 kwi 2020 o 15:56 Takashi Iwai <tiwai@...e.de> napisał(a):
>
> The commit 7ecced0934e5 ("gpio: exar: add a check for the return value
> of ida_simple_get fails") added a goto jump to the common error
> handler for ida_simple_get() error, but this is wrong in two ways:
> it doesn't set the proper return code and, more badly, it invokes
> ida_simple_remove() with a negative index that shall lead to a kernel
> panic via BUG_ON().
>
> This patch addresses those two issues.
>
> Fixes: 7ecced0934e5 ("gpio: exar: add a check for the return value of ida_simple_get fails")
> Cc: <stable@...r.kernel.org>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>

Patch applied for fixes, thanks!

Bart

Powered by blists - more mailing lists