lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Tue, 5 May 2020 09:52:04 -0700
From:   Linus Torvalds <>
To:     Christoph Hellwig <>
Cc:     Andrew Morton <>,
        Alexander Viro <>,
        Jeremy Kerr <>, Arnd Bergmann <>,
        Oleg Nesterov <>,
        "Eric W . Biederman" <>,
        "the arch/x86 maintainers" <>,
        linuxppc-dev <>,
        linux-fsdevel <>,
        Linux Kernel Mailing List <>
Subject: Re: remove set_fs calls from the coredump code v6

On Tue, May 5, 2020 at 3:13 AM Christoph Hellwig <> wrote:
> this series gets rid of playing with the address limit in the exec and
> coredump code.  Most of this was fairly trivial, the biggest changes are
> those to the spufs coredump code.

Ack, nice, and looks good.

The only part I dislike is how we have that 'struct compat_siginfo' on
the stack, which is a huge waste (most of it is the nasty padding to
128 bytes).

But that's not new, I only reacted to it because the code moved a bit.
We cleaned up the regular siginfo to not have the padding in the
kernel (and by "we" I mean "Eric Biederman did it after some prodding
as part of his siginfo cleanups" - see commit 4ce5f9c9e754 "signal:
Use a smaller struct siginfo in the kernel"),  and I wonder if we
could do something similar with that compat thing.

128 bytes of wasted kernel stack isn't the end of the world, but it's
sad when the *actual* data is only 32 bytes or so.


Powered by blists - more mailing lists