linux-kernel - Re: [PATCH] clk: Unlink clock if failed to prepare or enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <158870592381.26370.8784478076215991539@swboyd.mtv.corp.google.com>
Date:   Tue, 05 May 2020 12:12:03 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Marc Zyngier <maz@...nel.org>, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc:     Guenter Roeck <linux@...ck-us.net>,
        Michael Turquette <mturquette@...libre.com>
Subject: Re: [PATCH] clk: Unlink clock if failed to prepare or enable

Quoting Marc Zyngier (2020-05-05 07:09:53)
> On failing to prepare or enable a clock, remove the core structure
> from the list it has been inserted as it is about to be freed.
> 
> This otherwise leads to random crashes when subsequent clocks get
> registered, during which parsing of the clock tree becomes adventurous.
> 
> Observed with QEMU's RPi-3 emulation.
> 
> Fixes: 12ead77432f2 ("clk: Don't try to enable critical clocks if prepare failed")
> Signed-off-by: Marc Zyngier <maz@...nel.org>
> Cc: Guenter Roeck <linux@...ck-us.net>
> Cc: Stephen Boyd <sboyd@...nel.org>
> Cc: Michael Turquette <mturquette@...libre.com>
> ---

Applied to clk-fixes