linux-kernel - Re: + arch-x86-makefile-use-config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 5 May 2020 23:19:32 +0200
From:   Borislav Petkov <bp@...e.de>
To:     akpm@...ux-foundation.org
Cc:     mm-commits@...r.kernel.org, ndesaulniers@...gle.com,
        lkml <linux-kernel@...r.kernel.org>
Subject: Re: + arch-x86-makefile-use-config_shell.patch added to -mm tree

On Tue, May 05, 2020 at 02:13:01PM -0700, akpm@...ux-foundation.org wrote:
> 
> The patch titled
>      Subject: arch/x86/Makefile: use $(CONFIG_SHELL)
> has been added to the -mm tree.  Its filename is
>      arch-x86-makefile-use-config_shell.patch
> 
> This patch should soon appear at
>     http://ozlabs.org/~akpm/mmots/broken-out/arch-x86-makefile-use-config_shell.patch
> and later at
>     http://ozlabs.org/~akpm/mmotm/broken-out/arch-x86-makefile-use-config_shell.patch
> 
> Before you just go and hit "reply", please:
>    a) Consider who else should be cc'ed
>    b) Prefer to cc a suitable mailing list as well
>    c) Ideally: find the original patch on the mailing list and do a
>       reply-to-all to that, adding suitable additional cc's
> 
> *** Remember to use Documentation/process/submit-checklist.rst when testing your code ***
> 
> The -mm tree is included into linux-next and is updated
> there every 3-4 working days
> 
> ------------------------------------------------------
> From: Andrew Morton <akpm@...ux-foundation.org>
> Subject: arch/x86/Makefile: use $(CONFIG_SHELL)
> 
> When scripts/x86-check-compiler.sh doesn't have the x bit set:
> 
> q:/usr/src/25> make clean
> make: execvp: ./scripts/x86-check-compiler.sh: Permission denied
> 
> Fix this by using $(CONFIG_SHELL).
> 
> This will happen if the user downloads and applies patch-5.7.tar.gz, since
> patch(1) doesn't preserve the x bit.
> 
> Fixes: 73da86741e7f7 ("x86/build: Check whether the compiler is sane")
> Cc: Borislav Petkov <bp@...e.de>
> Cc: Nick Desaulniers <ndesaulniers@...gle.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---
> 
>  arch/x86/Makefile |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/arch/x86/Makefile~arch-x86-makefile-use-config_shell
> +++ a/arch/x86/Makefile
> @@ -2,7 +2,7 @@
>  # Unified Makefile for i386 and x86_64
>  
>  #  Check the compiler
> -sane_compiler := $(shell $(srctree)/scripts/x86-check-compiler.sh $(CC))
> +sane_compiler := $($(CONFIG_SHELL) $(srctree)/scripts/x86-check-compiler.sh $(CC))
>  $(if $(sane_compiler),$(error $(CC) check failed. Aborting),)
>  
>  # select defconfig based on actual architecture
> _

Ah, interesting.

Thanks Andrew, I'll queue it tomorrow through tip.

-- 
Regards/Gruss,
    Boris.

SUSE Software Solutions Germany GmbH, GF: Felix Imendörffer, HRB 36809, AG Nürnberg