linux-kernel - RE: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with rd_reg/wr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 6 May 2020 08:30:46 +0900
From:   "Hyunki Koo" <hyunki00.koo@...sung.com>
To:     "'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>
Cc:     "'Kukjin Kim'" <kgene@...nel.org>,
        "'Krzysztof Kozlowski'" <krzk@...nel.org>,
        "'Jiri Slaby'" <jslaby@...e.com>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>,
        <linux-serial@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v8 1/3] serial: samsung: Replace rd_regb/wr_regb with
 rd_reg/wr_reg

On Tuesday, May 5, 2020 at 2020 11:23:00 PM +0900, Greg Kroah-Hartman wrote:
> On Mon, Apr 20, 2020 at 10:32:56AM +0900, Hyunki Koo wrote:
> > This patch change the name of macro for general usage.
> >
> > Signed-off-by: Hyunki Koo <hyunki00.koo@...sung.com>
> 
> This patch series creates the following build error, which is not
> allowed:
> 
>   CC [M]  drivers/tty/serial/samsung_tty.o
> drivers/tty/serial/samsung_tty.c:186:13: warning: ‘wr_reg_barrier’
> defined but not used [-Wunused-function]
>   186 | static void wr_reg_barrier(struct uart_port *port, u32 reg, u32 val)
>       |             ^~~~~~~~~~~~~~
> 
> Please fix up and resend.  Always make sure you keep the reviewed-by
> tags from others as well.
> 
> greg k-h

I tested on latest kernel today one more time, there is no error and warning on my side, not only patch 1/3 and patch 3/3
Line 1735:   CC      drivers/tty/serial/samsung_tty.o
Line 343:   CC      drivers/tty/serial/samsung_tty.o

wr_reg_barrier is not defined in patch 1/3, 
and wr_reg_barrier is define and used in patch3/3
it might be no warning.