[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 05 May 2020 01:01:39 -0700
From: Joe Perches <joe@...ches.com>
To: Ard Biesheuvel <ardb@...nel.org>
Cc: Arvind Sankar <nivedita@...m.mit.edu>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
linux-efi <linux-efi@...r.kernel.org>, X86 ML <x86@...nel.org>
Subject: Re: [trivial PATCH] efi/libstub: Reduce efi_printk object size
On Tue, 2020-05-05 at 09:50 +0200, Ard Biesheuvel wrote:
> On Mon, 4 May 2020 at 20:29, Joe Perches <joe@...ches.com> wrote:
> > Use a few more common kernel styles.
> >
> > Trivially reduce efi_printk object size by using a dereference to
> > a temporary instead of multiple dereferences of the same object.
> >
> > Use efi_printk(const char *str) and static or static const for its
> > internal variables.
> >
> > Use the more common form of while instead of a for loop.
> >
> > Change efi_char16_printk argument to const.
> >
> > Signed-off-by: Joe Perches <joe@...ches.com>
>
> Thanks Joe.
No worries, it's not worth applying if
it's not good code. Just ignore it.
cheers, Joe
Powered by blists - more mailing lists